Skip to content

feat(publisheddata): automatically add issued date to datacite record#2484

Open
fpotier wants to merge 7 commits intomasterfrom
feat/add-date-issued
Open

feat(publisheddata): automatically add issued date to datacite record#2484
fpotier wants to merge 7 commits intomasterfrom
feat/add-date-issued

Conversation

@fpotier
Copy link
Member

@fpotier fpotier commented Jan 21, 2026

Description

Automatically adds a Date Issued when a DOI is registered to DataCite

Motivation

We need to add this entry to our future records to comply with a swiss metadata standard
In this PR it's not configurable and only occurs if it doesn't break validation.
Maybe it should be made opt-in/out?

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@fpotier fpotier force-pushed the feat/add-date-issued branch 2 times, most recently from f9e1a11 to cdf2d34 Compare January 21, 2026 16:01
@fpotier fpotier changed the title feat(publisheddata): automatically add issued date to datacite record feat: automatically add issued date to datacite record Jan 21, 2026
@fpotier fpotier force-pushed the feat/add-date-issued branch 2 times, most recently from b40bf22 to 6a6d6a2 Compare January 22, 2026 08:59
@fpotier fpotier changed the title feat: automatically add issued date to datacite record feat(publisheddata): automatically add issued date to datacite record Jan 22, 2026
@fpotier fpotier force-pushed the feat/add-date-issued branch from 6a6d6a2 to 3b924ae Compare January 22, 2026 09:19
@fpotier fpotier force-pushed the feat/add-date-issued branch from 3b924ae to b968bc0 Compare January 22, 2026 09:26
@fpotier fpotier changed the title feat(publisheddata): automatically add issued date to datacite record feat: automatically add issued date to datacite record Jan 22, 2026
@fpotier fpotier changed the title feat: automatically add issued date to datacite record feat(publisheddata): automatically add issued date to datacite record Jan 22, 2026
@fpotier fpotier marked this pull request as ready for review January 22, 2026 12:33
@fpotier fpotier requested a review from a team as a code owner January 22, 2026 12:33
@fpotier fpotier force-pushed the feat/add-date-issued branch 2 times, most recently from 1a801ac to fefa4ab Compare January 22, 2026 14:07
@fpotier fpotier force-pushed the feat/add-date-issued branch from fefa4ab to 13511fc Compare January 22, 2026 14:08
Copy link
Member

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Copy link
Member

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! good point about the comment, up to you!

@Junjiequan Junjiequan requested a review from nitrosx January 23, 2026 08:43
@Junjiequan
Copy link
Member

Please wait for merging until we review it

Copy link
Member

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but I am not sure that this is the right solution.
With this solution, we imply that the site admin or the facility data team wants to have this specific field "issued" in the metadata published on DataCite. We cannot make this assumption.
Also, it breaks away from the previous published data configuration which is managed in configuration, where we allow the site admin to configure the metadata submitted to DataCite.

I think that the Core team should do some brainstorming and discuss more the topic.

@nitrosx
Copy link
Member

nitrosx commented Jan 26, 2026

I think we should transfer this feature in this configuration file: publishedDataConfig.example.json

@fpotier
Copy link
Member Author

fpotier commented Jan 26, 2026

Good idea, but I am not sure that this is the right solution. With this solution, we imply that the site admin or the facility data team wants to have this specific field "issued" in the metadata published on DataCite. We cannot make this assumption. Also, it breaks away from the previous published data configuration which is managed in configuration, where we allow the site admin to configure the metadata submitted to DataCite.

I think that the Core team should do some brainstorming and discuss more the topic.

Thanks for the feedback, so you would suggest for now to add something like this to the config file?

"options": {
  "addDateIssued": true
}

I am currently working on making PSI's Scicat conformant with the swiss DataCite metadata standard and facing some limitations with the way it's implemented currently so I'd be interested to participate in future discussions

@nitrosx
Copy link
Member

nitrosx commented Jan 26, 2026

I see that as an acceptable solution, although not really generic!!!
I think the Issues field should be included in the published data configuration together with the fact that you want it populated with a specific date.
Hopefully it makes sense!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants