RELEASE 2026-02-02

[Junjiequan]

Description

Short description of the pull request

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

• Items added

Changes:

Please provide a list of the changes implemented by this PR

• changes made

Tests included

• Included for each change/fix?
• Passing? (Merge will not be approved unless this is checked)

Documentation

• swagger documentation updated [required]
• official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

• Does it require a specific version of the backend
• which version of the backend is required:

Summary by Sourcery

Introduce an admin area with configurable frontend settings and user management, add configurable scientific metadata number formatting, simplify table filtering UX, and refine layouts, configuration loading, and supporting infrastructure.

New Features:

• Add an admin dashboard with tabs for frontend configuration editing and a users list, protected by an admin route and exposed via the user menu.
• Introduce runtime configuration and users NgRx slices/effects to load and update frontend configuration and fetch users from the backend.
• Add a JSON preview dialog and custom JSONForms renderers (accordion arrays and expandable groups) to support rich editing of the frontend config schema.
• Make scientific metadata number formatting configurable via app configuration and apply it across metadata views, trees, inputs, and dataset tables, including export.

Bug Fixes:

• Ensure the admin guard correctly waits for login state, redirects unauthenticated users to login, and returns a 401 page for non-admin users.
• Correct ordering of dataset lifecycle history by returning events in reverse chronological order.
• Improve robustness of metadata number handling by ignoring non-finite values and not reformatting integers while still applying scientific notation where configured.

Enhancements:

• Move the public/my data toggle into the dataset filters panel, wiring it to public view mode and refreshing datasets and facet counts when changed.
• Unify checkbox filter collapsing behavior inside the shared-filter component and reuse shared styles across datasets and proposals side filters.
• Simplify the dynamic material table header by removing per-column header filters and the clear-filter menu action while tightening table row heights and layout.
• Refine layouts and spacing for dashboards, breadcrumbs, main layout padding, and jsonforms-generated forms, including tweaks for boolean controls and card content padding.
• Update app configuration and theme loading services to use modern RxJS patterns, provide default metadata float formatting, and support new config fields.
• Display an Admin Settings (Beta) entry in the header menu for admin users and adjust the dashboard/table toolbars and breadcrumb appearance.
• Initialize publish metadata from configured default values and format scientific metadata consistently in view and tree components.

Build:

• Upgrade GitHub Actions workflows to newer versions of cache, upload-artifact, and dependabot metadata actions.
• Bump frontend dependencies including the SciCat Angular SDK and TypeScript/node typings and add baseline-browser-mapping for test/browser support.

CI:

• Adjust Cypress tests, including removing the proposal column filter test, increasing a datasets config wait timeout, and updating coverage artifact handling.

Documentation:

• Tidy project documentation by removing the SonarCloud badge from the README.

Tests:

• Extend and adapt unit tests for datasets filters, metadata views and trees, scientific metadata inputs, app configuration, and instruments mapping to cover new behaviors and configuration-driven formatting.
• Add NgRx tests around runtime configuration selectors/reducers and update existing specs to account for the new configuration service usage.

[sourcery-ai]

Hey - I've found 2 issues, and left some high level feedback:

• In runtime-config.reducer.ts you log every [RunTimeConfig] action via console.log, which will be noisy in production; consider removing this or guarding it behind an environment/debug flag.
• The updated FormatNumberPipe now stringifies all values when metadataFloatFormatEnabled is false (previously non‑scientific numbers were returned as numbers); if any consumers rely on numeric types for bindings or calculations, you may want to preserve the original type in the non-formatting case.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `runtime-config.reducer.ts` you log every `[RunTimeConfig]` action via `console.log`, which will be noisy in production; consider removing this or guarding it behind an environment/debug flag.
- The updated `FormatNumberPipe` now stringifies all values when `metadataFloatFormatEnabled` is false (previously non‑scientific numbers were returned as numbers); if any consumers rely on numeric types for bindings or calculations, you may want to preserve the original type in the non-formatting case.

## Individual Comments

### Comment 1
<location> `src/app/admin/admin-dashboard/admin-dashboard.component.ts:63-64` </location>
<code_context>
+      },
+    ];
+
+    this.route.firstChild?.url
+      .subscribe((childUrl) => {
+        const tab = childUrl.length === 1 ? childUrl[0].path : "configuration";
+        this.fetchDataForTab(TAB[tab]);
</code_context>

<issue_to_address>
**issue (bug_risk):** The subscription to `route.firstChild?.url` is immediately unsubscribed, likely preventing the initial tab's data fetch.

Since you unsubscribe immediately, this observable is likely torn down before it emits, so `fetchDataForTab` may never run on the initial navigation (e.g. direct hit to `/admin/configuration`). Instead, either keep the subscription and clean it up in `ngOnDestroy`, use `this.route.snapshot.firstChild?.url` for initial tab detection, or hook into router events to react to child route activation. As written, load actions may only dispatch when the user clicks tabs, not on first load.
</issue_to_address>

### Comment 2
<location> `src/app/state-management/reducers/runtime-config.reducer.ts:31-32` </location>
<code_context>
+  state: RuntimeConfigState | undefined,
+  action: Action,
+) => {
+  if (action.type.indexOf("[RunTimeConfig]") !== -1) {
+    console.log("Action came in! " + action.type);
+  }
+  return reducer(state, action);
</code_context>

<issue_to_address>
**issue:** Reducer logs every runtime-config action to the console, which is noisy and side-effectful in reducers.

Having `console.log` in a reducer violates the expectation that reducers are pure and adds noisy logs in production. If this is for debugging, consider moving it into an NgRx meta-reducer, guarding it with a dev-only check (e.g. `if (!environment.production)`), or removing it before merge.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}