Handle edge-cases of inverted root pairs in the condition rootfinding#1292
Open
DaniGlez wants to merge 9 commits intoSciML:masterfrom
Open
Handle edge-cases of inverted root pairs in the condition rootfinding#1292DaniGlez wants to merge 9 commits intoSciML:masterfrom
DaniGlez wants to merge 9 commits intoSciML:masterfrom
Conversation
Contributor
Author
|
Also please squash if merging, I was a bit sloppy with the WIP commits 😅 |
Member
|
Needs a test |
Contributor
Author
|
Test added; I would still like SciML/NonlinearSolve.jl#861 to be merged first, so that the |
Contributor
Author
|
Fuzzer script for posterity, in case the test needs to be recreated in the future: https://gist.github.com/DaniGlez/6100f2530fc76d4f9673a8f9f7422564 |
Contributor
Author
|
I think the JumpProcesses test failure should be solved by SciML/NonlinearSolve.jl#861 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1290 (see the issue discussion for context)
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.