Skip to content

Handle edge-cases of inverted root pairs in the condition rootfinding#1292

Open
DaniGlez wants to merge 9 commits intoSciML:masterfrom
DaniGlez:master
Open

Handle edge-cases of inverted root pairs in the condition rootfinding#1292
DaniGlez wants to merge 9 commits intoSciML:masterfrom
DaniGlez:master

Conversation

@DaniGlez
Copy link
Contributor

@DaniGlez DaniGlez commented Mar 3, 2026

Closes #1290 (see the issue discussion for context)

Checklist

Additional context

Add any other context about the problem here.

@DaniGlez
Copy link
Contributor Author

DaniGlez commented Mar 3, 2026

Also please squash if merging, I was a bit sloppy with the WIP commits 😅

@ChrisRackauckas
Copy link
Member

Needs a test

@DaniGlez
Copy link
Contributor Author

DaniGlez commented Mar 5, 2026

Test added; I would still like SciML/NonlinearSolve.jl#861 to be merged first, so that the ModAB behavior is consistent (if it hits the buggy path, a slightly different original root might be found)

@DaniGlez
Copy link
Contributor Author

DaniGlez commented Mar 5, 2026

Fuzzer script for posterity, in case the test needs to be recreated in the future: https://gist.github.com/DaniGlez/6100f2530fc76d4f9673a8f9f7422564

@DaniGlez
Copy link
Contributor Author

DaniGlez commented Mar 5, 2026

I think the JumpProcesses test failure should be solved by SciML/NonlinearSolve.jl#861 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RightRootFind and LeftRootFind have opposite behavior in some cases

2 participants