Fix all CI failures: typos, Runic, test compat, callback test#419
Merged
ChrisRackauckas merged 1 commit intomasterfrom Mar 18, 2026
Merged
Fix all CI failures: typos, Runic, test compat, callback test#419ChrisRackauckas merged 1 commit intomasterfrom
ChrisRackauckas merged 1 commit intomasterfrom
Conversation
2 tasks
f461ac4 to
2c60739
Compare
- Fix typos: "containig" → "containing", "Webiste" → "Website", "comparsion" → "comparison" - Apply Runic formatting to test/jet_tests.jl - Lower SciMLBase compat in test/Project.toml from 2.144.0 to 2.128 to match main Project.toml (fixes alldeps Julia 1.10 resolver failure) - Fix DiscreteCallback test DimensionMismatch: GPU tstop handling saves fewer points than Vern9, so compare interpolated values instead of raw .u arrays Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2c60739 to
2835588
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all four pre-existing CI failures on master.
Fixes
1. Spell Check (typos)
containig→containinginsrc/ensemblegpukernel/lowerlevel_solve.jlWebiste→Websiteinsrc/ensemblegpukernel/tableaus/verner_tableaus.jlcomparsion→comparisoninREADME.md2. Runic formatting
test/jet_tests.jl3. alldeps Julia 1.10 resolver failure
SciMLBasecompat intest/Project.tomlfrom2.144.0to2.128to match the mainProject.tomlbound. The higher bound causedempty intersection between SciMLBase@2.138.0 and project compatibility 2.144.0on Julia 1.10.4. DiscreteCallback DimensionMismatch
dtto land exactly on the tstop in one step, while Vern9 saves both the pre-tstop step and the tstop. Withdt=0.01f0over[0,10], Float32 drift places a step at3.9999967just before4.0, so Vern9 saves 1002 points vs GPU's 1001..uarrays.Test plan