Skip to content

Fix all CI failures: typos, Runic, test compat, callback test#419

Merged
ChrisRackauckas merged 1 commit intomasterfrom
fix-ci-failures
Mar 18, 2026
Merged

Fix all CI failures: typos, Runic, test compat, callback test#419
ChrisRackauckas merged 1 commit intomasterfrom
fix-ci-failures

Conversation

@ChrisRackauckas
Copy link
Member

Summary

Fixes all four pre-existing CI failures on master.

Fixes

1. Spell Check (typos)

  • containigcontaining in src/ensemblegpukernel/lowerlevel_solve.jl
  • WebisteWebsite in src/ensemblegpukernel/tableaus/verner_tableaus.jl
  • comparsioncomparison in README.md

2. Runic formatting

  • Applied Runic to test/jet_tests.jl

3. alldeps Julia 1.10 resolver failure

  • Lowered SciMLBase compat in test/Project.toml from 2.144.0 to 2.128 to match the main Project.toml bound. The higher bound caused empty intersection between SciMLBase@2.138.0 and project compatibility 2.144.0 on Julia 1.10.

4. DiscreteCallback DimensionMismatch

  • GPU kernel tstop handling shortens dt to land exactly on the tstop in one step, while Vern9 saves both the pre-tstop step and the tstop. With dt=0.01f0 over [0,10], Float32 drift places a step at 3.9999967 just before 4.0, so Vern9 saves 1002 points vs GPU's 1001.
  • Fixed by comparing interpolated endpoint values instead of raw .u arrays.

Test plan

  • DiscreteCallback fix verified locally (GPUTsit5, GPUVern7, GPUVern9 all pass)
  • CI should now pass across all Julia versions and backends

- Fix typos: "containig" → "containing", "Webiste" → "Website",
  "comparsion" → "comparison"
- Apply Runic formatting to test/jet_tests.jl
- Lower SciMLBase compat in test/Project.toml from 2.144.0 to 2.128
  to match main Project.toml (fixes alldeps Julia 1.10 resolver failure)
- Fix DiscreteCallback test DimensionMismatch: GPU tstop handling saves
  fewer points than Vern9, so compare interpolated values instead of
  raw .u arrays

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas merged commit 5a1cb24 into master Mar 18, 2026
19 of 27 checks passed
@ChrisRackauckas ChrisRackauckas deleted the fix-ci-failures branch March 18, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant