steps towards iterative solvers + tests for general numbers#263
Open
j-fu wants to merge 2 commits intoSciML:mainfrom
Open
steps towards iterative solvers + tests for general numbers#263j-fu wants to merge 2 commits intoSciML:mainfrom
j-fu wants to merge 2 commits intoSciML:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main JuliaLang/julia#263 +/- ##
===========================================
- Coverage 70.27% 52.68% -17.59%
===========================================
Files 14 14
Lines 841 837 -4
===========================================
- Hits 591 441 -150
- Misses 250 396 +146
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
Member
|
I don't think we want to do this approach. Instead, we should do an approach like https://github.com/SciML/NonlinearSolve.jl/blob/master/src/ad.jl where an overload catches the floats and just makes BLAS solve the problem in Float64s by appropriately reinterpreting. That would be faster than using the BLAS fallbacks. |
Member
|
Dual number support needs to happen differently, but the rest is fine? Can you rebase this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't work for Duals in the moment