Fix BoundsError in upwind_difference for nonuniform grids (Fixes #340)#533
Open
utkuyilmaz1903 wants to merge 1 commit intoSciML:masterfrom
Open
Fix BoundsError in upwind_difference for nonuniform grids (Fixes #340)#533utkuyilmaz1903 wants to merge 1 commit intoSciML:masterfrom
utkuyilmaz1903 wants to merge 1 commit intoSciML:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #340 where providing a nonuniform grid (as an
AbstractVector) to theUpwindSchemeresulted in aBoundsError.Cause of the Bug:
In
_upwind_differenceforDX <: AbstractVector, theD.offsidevalue defaults to0. This caused the boundary check(II[j] <= D.offside)to fail at the lower boundary (II[j] == 1). Consequently, the algorithm incorrectly executed the interior stencil logic, attempting to access index0and throwing aBoundsError.Solution:
Replaced the reliance on
D.offsidewith a calculatedactual_offside = D.stencil_length - 1. The boundary checks now correctly identify when the stencil approaches the domain edges, appropriately applying the boundary coefficients (low_boundary_coefsandhigh_boundary_coefs) without out-of-bounds indexing.