feat: automatically combine SCCs in SCCNonlinearProblem #4361
Merged
AayushSabharwal merged 6 commits intomasterfrom Mar 17, 2026
Merged
feat: automatically combine SCCs in SCCNonlinearProblem #4361AayushSabharwal merged 6 commits intomasterfrom
AayushSabharwal merged 6 commits intomasterfrom
Conversation
AayushSabharwal
force-pushed
the
as/combine-sccs
branch
2 times, most recently
from
b640a93 to
0e91429
Compare
Member
Author
|
This PR is on hold, both until I can fix the failures it introduces and because the number of failures on master make me hesitant to merge something this disruptive. |
AayushSabharwal
force-pushed
the
as/combine-sccs
branch
from
0e91429 to
f93c11c
Compare
AayushSabharwal
force-pushed
the
as/combine-sccs
branch
from
f93c11c to
38de387
Compare
AayushSabharwal
changed the title
AayushSabharwal
force-pushed
the
as/combine-sccs
branch
from
38de387 to
3144bd0
Compare
AayushSabharwal
force-pushed
the
as/combine-sccs
branch
from
3144bd0 to
4bf07b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.