Adding option to specify whether they Move Channel and want to sync p…#184
Open
ArgontTj wants to merge 1 commit intoScootKit:mainfrom
Open
Adding option to specify whether they Move Channel and want to sync p…#184ArgontTj wants to merge 1 commit intoScootKit:mainfrom
ArgontTj wants to merge 1 commit intoScootKit:mainfrom
Conversation
…ermissions or not.
1. The Execution Logic (subcommands)
We use the lockPermissions property in setParent to handle the sync.
2. The Command Configuration (config)
Add the new BOOLEAN and STRING types to the options arrays.
Key Improvements :
- Permission Logic: Used { lockPermissions: sync }. When true, it behaves exactly like dragging a channel in the Discord UI and clicking "Sync Permissions."
- Audit Transparency: Every action now supports a reason which will appear in the Server Settings > Audit Log.
- Type Safety: I used integer types (e.g., type: 5 for Boolean) which are standard for raw object configurations in Discord.js, but ensured the logic remains clean.
SCDerox
requested changes
Mar 12, 2026
Member
SCDerox
left a comment
SCDerox
left a comment
There was a problem hiding this comment.
Thanks for taking the time to submit this PR.
This code does not work since all command sync metadata has been removed. When submitting code, please ensure it works by testing it in a local environment.
Additionally, users overwriting the reason creates a dangerous lack of accountability. Instead of just using the reason passed by the user, append the "Moved by" part to the reason to ensure admins can see in the log who moved a channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ermissions or not.
The Execution Logic (subcommands) We use the lockPermissions property in setParent to handle the sync.
The Command Configuration (config) Add the new BOOLEAN and STRING types to the options arrays.
Key Improvements :
Permission Logic: Used { lockPermissions: sync }. When true, it behaves exactly like dragging a channel in the Discord UI and clicking "Sync Permissions."
Audit Transparency: Every action now supports a reason which will appear in the Server Settings > Audit Log.
Type Safety: I used integer types (e.g., type: 5 for Boolean) which are standard for raw object configurations in Discord.js, but ensured the logic remains clean.