Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project by moving dependency management and builds to Poetry and by removing the federated ID pool functionality. Key changes include:
- Introduction of a pyproject.toml for Poetry-based dependency management.
- Updates to CI workflows and tests to align with the Poetry build system and Python 3.11.
- Removal of code related to federated ID, credentials, and signature generation features.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | New project configuration using Poetry |
| .github/workflows/*.yml | Updated workflows to install dependencies via Poetry and Python 3.11 |
| docs_source/conf.py | Updated release handling and copyright for 2025 |
| scribeauth/scribeauth.py | Reworked authentication logic, replaced TypedDicts with dataclasses, and removed federated ID features |
| tests/test_scribeauth.py | Updated tests to use pytest and removed federated ID tests |
| scribeauth/main.py | Updated CLI to use new ScribeAuth constructor and dataclass checks |
| README.md & LICENSE.md | Adjusted documentation and license year |
| scribeauth/init.py | Reflected removal of federated functionality |
| setup.py | Removed in favor of Poetry's pyproject.toml |
Comments suppressed due to low confidence (2)
scribeauth/scribeauth.py:259
- Avoid using a bare except clause here; instead, catch specific exceptions to prevent masking unexpected errors.
except:
tests/test_scribeauth.py:31
- [nitpick] Consider using a consistent test class structure across all tests; for example, either subclass unittest.TestCase or use plain pytest functions consistently.
class TestScribeAuthGetTokensNoMFA:
fix coverage fix coverage fix coverage for real fix coverage for real
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.