Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for self-managed token signing and decoding, enabling users with their own SSO systems to self-sign tokens. Key changes include:
- Updating the README with documentation and usage examples for self-signing tokens.
- Introducing a SelfManagedSigner class and a decode_self_signed_jwt helper in scribeauth.py.
- Adding tests for self-signed token generation and decoding, and updating dependencies in pyproject.toml.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Added documentation and examples for self-signing tokens. |
| scribeauth/scribeauth.py | Added SelfManagedSigner implementation and token decoding helper function. |
| tests/test_scribeauth.py | Added new tests for self-signed token functionality and updated test helpers. |
| pyproject.toml | Included pyjwt as a dependency for token signing. |
| scribeauth/init.py | Exported SelfManagedSigner and decode_self_signed_jwt for public API usage. |
Comments suppressed due to low confidence (2)
scribeauth/scribeauth.py:369
- A duplicate definition of SelfManagedSigner appears to be introduced. Ensure that only one implementation exists to avoid conflicts.
@dataclass
scribeauth/scribeauth.py:385
- The docstring is misleading; consider updating it to 'Signs a JWT payload using the private key' or similar to accurately describe the functionality.
"Signs the private key with the private key."
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to self-sign tokens. Also adds a little helper to decode the token to inspect its content.