[FIX] codegen/entity: Support multi argument extra attribute #2560
+17
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive_enum-multi_argument_attribute
…tive_enum-multi_argument_attribute
tyt2y3
approved these changes
Jan 15, 2026
Huliiiiii
added a commit
that referenced
this pull request
Jan 16, 2026
This reverts commit 24335ad.
Member
|
I have to revert this because the test input is incorrect. The test input should be split by Example: And in this case syn will panic because it can’t parse it into a valid TokenStream. |
Huliiiiii
added a commit
that referenced
this pull request
Jan 16, 2026
Reverts #2560 I have to revert this because the test input is incorrect. The test input should be split by `,`. Example: ``` [ r#"serde(rename_all = "camelCase""#, r#" rename = "test")"#, r#"ts(export"#, r#" export_to = "path")"# ] ``` And in this case syn will panic because it can’t parse it into a valid TokenStream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Entity generation fails if
model-extra-attributesinclude a comma surrounded by parentheses #2063Bug Fixes
Before this commit, using
--*-extra-attributeswith an attribute containing a comma (several arguments) did not work (example--model-extra-attributes=“graphql(complex, name=”users“)Changes