Optimize exists #2909
Merged
Optimize exists #2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Huliiiiii
commented
Jan 12, 2026
Huliiiiii
commented
- Closes Redundant query in PaginatorTrait::exists() #2908
tyt2y3
approved these changes
Jan 13, 2026
Member
tyt2y3
left a comment
tyt2y3
left a comment
There was a problem hiding this comment.
do we need to add a test case or there is already coverage?
Huliiiiii
force-pushed
the
entity-exists
branch
5 times, most recently
from
ac2aad9 to
b6fd8fa
Compare
Huliiiiii
force-pushed
the
entity-exists
branch
from
b6fd8fa to
5a1d504
Compare
tyt2y3
approved these changes
Jan 15, 2026
tyt2y3
reviewed
Jan 16, 2026
| } | ||
| } | ||
|
|
||
| #[async_trait::async_trait] |
Member
There was a problem hiding this comment.
Suggested change
| #[async_trait::async_trait] |
Member
Author
There was a problem hiding this comment.
async fn in trait can’t mark the future as Send and Sync, but we can use impl future instead. Which do you prefer?
tyt2y3
reviewed
Jan 16, 2026
Comment on lines
-280
to
-282
| async fn exists(self, db: &'db C) -> Result<bool, DbErr> | ||
| where | ||
| Self: Send + Sized, |
Member
There was a problem hiding this comment.
I am thinking whether we should keep this, at least leave behind a deprecated notice?
Member
Author
There was a problem hiding this comment.
It was added in v2.0, so I think we can move it directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.