Skip to content

Fix UInt16 writing + expose length value #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimoV8 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix UInt16 writing + expose length value #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions McProtocol/MCProtocol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ public class PLCData<T> : PLCData
{
Mitsubishi.PlcDeviceType DeviceType;
int Address;
int Length;
int LENGTH;//Length in bytes
public int Length { get; private set; }
public int BytesLength { get; private set; } //Length in bytes
byte[] bytes;
public PLCData(Mitsubishi.PlcDeviceType DeviceType, int Address, int Length)
{
Expand All @@ -38,41 +38,41 @@ public PLCData(Mitsubishi.PlcDeviceType DeviceType, int Address, int Length)
switch (t)
{
case "Boolean":
this.LENGTH = (Length / 16 + (Length % 16 > 0 ? 1 : 0)) * 2;
this.BytesLength = (Length / 16 + (Length % 16 > 0 ? 1 : 0)) * 2;
this.Length = Length;
break;
case "Int32":
this.LENGTH = 4 * Length;
this.BytesLength = 4 * Length;
this.Length = Length * 2;
break;
case "Int16":
this.LENGTH = 2 * Length;
this.BytesLength = 2 * Length;
this.Length = Length;
break;
case "UInt16":
this.LENGTH = 2 * Length;
this.BytesLength = 2 * Length;
this.Length = Length;
break;
case "UInt32":
this.LENGTH = 4 * Length;
this.BytesLength = 4 * Length;
this.Length = Length * 2;
break;
case "Single":
this.LENGTH = 4 * Length;
this.BytesLength = 4 * Length;
this.Length = Length * 2;
break;
case "Double":
this.LENGTH = 8 * Length;
this.BytesLength = 8 * Length;
this.Length = Length * 4;
break;
case "Char":
this.LENGTH = Length;
this.BytesLength = Length;
this.Length = Length;
break;
default:
throw new Exception("Type not supported by PLC.");
}
this.bytes = new byte[this.LENGTH];
this.bytes = new byte[this.BytesLength];

}
public T this[int i]
Expand Down Expand Up @@ -152,7 +152,7 @@ public T this[int i]
case "UInt16":
u.UINT = Convert.ToUInt16(value);
this.bytes[i * 2] = u.a;
this.bytes[i * 2] = u.b;
this.bytes[i * 2 + 1] = u.b;
return;
case "Single":
u.REAL = Convert.ToSingle(value);
Expand Down