Port the preprocessing/meshing folder from the SeisSol repository to here#48
Open
davschneller wants to merge 6 commits intomasterfrom
Open
Port the preprocessing/meshing folder from the SeisSol repository to here#48davschneller wants to merge 6 commits intomasterfrom
preprocessing/meshing folder from the SeisSol repository to here#48davschneller wants to merge 6 commits intomasterfrom
Conversation
Contributor
|
Hi, |
Contributor
Author
|
We could do that, I'd say. If we merge everything into a preprocessing repo, then maybe also include the Geodata repo (https://github.com/SeisSol/Geodata ) somehow? To throw in some alternatives as well:
|
Contributor
great!
not so great - submodules are awful and especially in this case IMO not useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR copies all programs in the
preprocessing/meshingto this repository. Also,gmsh2gambitnow supports CMake (scons is still left in for now, but we may remove it freely). The scripts contained inpreprocessing/meshingitself are now located inlegacy_scripts(if they are needed at all by now).This PR is a prerequisite for SeisSol/SeisSol#872 to be merged.