Open
Conversation
sebwolf-de
reviewed
Jul 25, 2023
Contributor
sebwolf-de
left a comment
sebwolf-de
left a comment
There was a problem hiding this comment.
Hi,
good work! From a user perspective: I don't understand how the bmin/bmax and the bper interact: Why can't I just provide bmaxx = bminx = periodic? And throw an error if bmaxx=periodic bminx != periodic?
Also an xdmf file would be nice to visualize the mesh with paraview.
* add a slim Xdmf and XML writer * add HDF5 error checking functions * update boundary format info
Contributor
Author
|
Sorry for the very late update; I've finally gotten to addressing the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PUMLcube, a replica of
cube_cfor the PUML format, as used by PUML2. With maybe a slightly different tetrahedron decomposition for the cubes.And no, it does not make PUML2 support periodic boundary conditions automatically. :)It only adds an
identifydataset to the HDF5 file. That is, periodic boundary conditions are implemented by identifying vertices with each other, i.e. we group the connectivity of the vertices, but they still have different coordinates. The identify array then lets all grouped vertices point to one head vertex by ID (and the head vertex points to itself). Of course, each unique (non-grouped) vertex is its own head vertex.Coincidentally, that's sort of the same idea like the gmsh format also supports (in the
$Periodicsection).However, for all of this to work, we'll need to extend PUML2 still. Somehow. We'll see.SeisSol/SeisSol#1395 adds support to PUML2 and SeisSol.