Add periodic mesh support for GMSH; format everything a bit#90
Merged
davschneller merged 15 commits intomasterfrom Oct 19, 2025
Merged
Add periodic mesh support for GMSH; format everything a bit#90davschneller merged 15 commits intomasterfrom
davschneller merged 15 commits intomasterfrom
Conversation
Contributor
with kubuntu 24, I get: maybe it could be worth using an older rev v0.13.0? EDIT: could update nvm with but do we want to force developers to do this update for a linter?
Is this language_version specifier really necessary? |
Thomas-Ulrich
approved these changes
Oct 15, 2025
Contributor
Thomas-Ulrich
left a comment
There was a problem hiding this comment.
LGTM. See also the 2 comments about precommits.
Contributor
Author
|
Thanks for the feedback! Regarding the pre-commit comments:
(all of these changes to the pre-commit config will also need to be propagated to SeisSol and a PSpaMM PR probably) |
Contributor
|
ok then forget about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
third_partyfolder).