Open
Conversation
This reverts commit 2cf4a16.
…Sol/Sampler into thomas/kajiura_filter_nofft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I fixed errors in the Kajiura filter FFT implementation (in particular the fixed depth has to be given as a parameter and sigma must be computed with this depth, not with h_max).
I've also added an implementation without FFT allowing variable depths, which is actually not that slow.
The figure shows eta_diff at 16s with:
FFT (depth=1000m), FFT (depth 100m), non fft:
See the thesis of Max for reference.