Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tensor's stride is divisible by the vector width then memory is always assumed to be aligned. In some situations one might want to work with unaligned memory even if the stride is divisible by the vector width (e.g. when interfacing existing data structures without aligned memory allocation).
With this PR one may pass Alignment.Unaligned to the alignStride option to enforce unaligned memory access. The previous "False" value maps to Alignment.Automatic and the previous "True" value maps to Alignment.Aligned. Passing True and False is still ok such that existing code does not need to be changed.