fix(sandbox): add optional configurations for OSS, NAS, and PolarFS#61
Merged
fix(sandbox): add optional configurations for OSS, NAS, and PolarFS#61
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #54 by exposing sandbox mount configuration options (OSS/NAS/PolarFS) through the higher-level SandboxToolSet API, so callers can pass these settings without monkey-patching lower layers.
Changes:
- Added optional
oss_mount_config,nas_config, andpolar_fs_configparameters toSandboxToolSetand propagated them intoSandbox.create(). - Threaded the same optional configs through
CodeInterpreterToolSet,BrowserToolSet, and thesandbox_toolset()factory. - Exported
PolarFsMountConfigfromagentrun.sandboxfor easier imports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentrun/sandbox/init.py | Re-exports PolarFsMountConfig via module imports and __all__. |
| agentrun/integration/builtin/sandbox.py | Adds optional mount configs to ToolSet constructors and forwards them into sandbox creation + toolset factory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Introduced optional parameters for OSSMountConfig, NASConfig, and PolarFsConfig in SandboxToolSet and its subclasses. - Updated sandbox_toolset function to accept new configuration options. - Adjusted imports in sandbox module to include PolarFsMountConfig. This enhancement allows for more flexible sandbox configurations, improving integration capabilities. Signed-off-by: Sodawyx <sodawyx@126.com>
fbc9eb7 to
bf299b8
Compare
OhYee
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #54
This enhancement allows for more flexible sandbox configurations, improving integration capabilities.
Fix bugs
Bug detail
Pull request tasks
Update docs
Reason for update
Pull request tasks
Add contributor
Contributed content
Content detail
Others
Reason for update