Skip to content

fix(sandbox): add optional configurations for OSS, NAS, and PolarFS#61

Merged
OhYee merged 1 commit intomainfrom
fix-sandbox-toolset-support-oss
Mar 3, 2026
Merged

fix(sandbox): add optional configurations for OSS, NAS, and PolarFS#61
OhYee merged 1 commit intomainfrom
fix-sandbox-toolset-support-oss

Conversation

@Sodawyx
Copy link
Collaborator

@Sodawyx Sodawyx commented Mar 3, 2026

Fix issue #54

  • Introduced optional parameters for OSSMountConfig, NASConfig, and PolarFsConfig in SandboxToolSet and its subclasses.
  • Updated sandbox_toolset function to accept new configuration options.
  • Adjusted imports in sandbox module to include PolarFsMountConfig.

This enhancement allows for more flexible sandbox configurations, improving integration capabilities.

Thank you for creating a pull request to contribute to Serverless Devs agentrun-sdk-python code! Before you open the request please answer the following questions to help it be more easily integrated. Please check the boxes "[ ]" with "[x]" when done too.
Please select one of the PR types below to complete


Fix bugs

Bug detail

The specific manifestation of the bug or the associated issue.

Pull request tasks

  • Add test cases for the changes
  • Passed the CI test

Update docs

Reason for update

Why do you need to update your documentation?

Pull request tasks

  • Update Chinese documentation
  • Update English documentation

Add contributor

Contributed content

  • Code
  • Document

Content detail

if content_type == 'code' || content_type == 'document':
    please tell us `PR url`,like: https://github.com/Serverless-Devs/agentrun-sdk-python/pull/1
else:
    please describe your contribution in detail

Others

Reason for update

Why do you need to update your documentation?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #54 by exposing sandbox mount configuration options (OSS/NAS/PolarFS) through the higher-level SandboxToolSet API, so callers can pass these settings without monkey-patching lower layers.

Changes:

  • Added optional oss_mount_config, nas_config, and polar_fs_config parameters to SandboxToolSet and propagated them into Sandbox.create().
  • Threaded the same optional configs through CodeInterpreterToolSet, BrowserToolSet, and the sandbox_toolset() factory.
  • Exported PolarFsMountConfig from agentrun.sandbox for easier imports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
agentrun/sandbox/init.py Re-exports PolarFsMountConfig via module imports and __all__.
agentrun/integration/builtin/sandbox.py Adds optional mount configs to ToolSet constructors and forwards them into sandbox creation + toolset factory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Introduced optional parameters for OSSMountConfig, NASConfig, and PolarFsConfig in SandboxToolSet and its subclasses.
- Updated sandbox_toolset function to accept new configuration options.
- Adjusted imports in sandbox module to include PolarFsMountConfig.

This enhancement allows for more flexible sandbox configurations, improving integration capabilities.

Signed-off-by: Sodawyx <sodawyx@126.com>
@Sodawyx Sodawyx force-pushed the fix-sandbox-toolset-support-oss branch from fbc9eb7 to bf299b8 Compare March 3, 2026 09:51
@OhYee OhYee merged commit a74d7d2 into main Mar 3, 2026
2 checks passed
@OhYee OhYee deleted the fix-sandbox-toolset-support-oss branch March 3, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants