fix(NixOS): check nix paths for binaries in udev hiding rules#541
fix(NixOS): check nix paths for binaries in udev hiding rules#541ShadowApex merged 1 commit intomainfrom
Conversation
|
🎉 This PR is included in version 0.75.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Wouldn't the better approach be for InputPlumber itself to traverse through the path everywhere instead of using some hardcoded paths and if that fails shelling out? This should be relatively trivial to implement ourselves, or there's this crate if you're okay with adding another dependency. |
|
Also, completely separately: why is the chmod command needed in the udev rule if we're setting Thank you both on your work on InputPlumber and making sure it works on NixOS! |
You're absolutely right, that is a much better solution 😄 . Since this is relatively trivial to implement (parse
Thanks for your comments! In our testing, we found that just setting |
Since adding the devnode moving logic, inputplumber would fail in finding the correct binary paths for
chmodandmv. This change fixes that by checking for the binaries in NixOS paths. Otherwise it will try to use thewhichbuilt-in shell command to discover the path.