Added API for adding and updating notes and phones outside the change…#720
Added API for adding and updating notes and phones outside the change…#720
Conversation
schroerbrian
left a comment
There was a problem hiding this comment.
Looks great. There are some test failures, but I assume you are working on those
config/routes.rb
Outdated
| post :create | ||
| put :update |
There was a problem hiding this comment.
I think these routes are already handled automatically by the resources method, according to https://guides.rubyonrails.org/routing.html#crud-verbs-and-actions. In fact, I think you're actually adding different routes compared to the Rails builtin ones, since this will create the create route at /notes/create, whereas the builtin is just at /notes (with a POST method), and yours will create the update route at /notes/update, whereas the builtin is /notes/:id/, where :id is the ID of the resource in the URL itself rather than as a parameter.
richardxia
left a comment
There was a problem hiding this comment.
Changes mostly LGTM, but you're failing some Postman tests.
… request paradigm