Skip to content

Fix/object detection#52

Open
MarcOlivierFecteau wants to merge 4 commits intoSherbyRobotics:ros2from
MarcOlivierFecteau:fix/object_detection
Open

Fix/object detection#52
MarcOlivierFecteau wants to merge 4 commits intoSherbyRobotics:ros2from
MarcOlivierFecteau:fix/object_detection

Conversation

@MarcOlivierFecteau
Copy link
Collaborator

Fixes the logic around the processing of the closest detected object. No error caused by lookup_transform or closestObject[2] > 0 SHOULD occur.

NOTES:

  • "The maths aren't mathing": the computed distance and angle of the processed object seem incorrect from my testing.

NOTES:

- The (commented out) fix does not work: the values for the distance and
  angle of the processed object are incorrect.
@MarcOlivierFecteau MarcOlivierFecteau self-assigned this Nov 26, 2025
@MarcOlivierFecteau MarcOlivierFecteau added the bug Something isn't working label Nov 26, 2025
@MarcOlivierFecteau
Copy link
Collaborator Author

Important

This PR SHOULD be merged with the squash and merge strategy, since most commits don't actually fix the issue (they are mostly about esthetics).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant