[WIP][Feature] Add admin authenticate middleware to "/app" routes#66
Closed
k-melnychuk wants to merge 1 commit intoShopify:mainfrom
Closed
[WIP][Feature] Add admin authenticate middleware to "/app" routes#66k-melnychuk wants to merge 1 commit intoShopify:mainfrom
k-melnychuk wants to merge 1 commit intoShopify:mainfrom
Conversation
k-melnychuk
force-pushed
the
feature/auth-middleware
branch
from
1fa5169 to
8dc1d07
Compare
Contributor
|
Hey @k-melnychuk 👋 This is awesome. Thanks so much for submitting this PR. We really want middleware, but I think we'll likely add code to the In the meantime, ofc feel free to take this approach. It's likely we'll take a similar one, just inside the package. Again, thanks for the PR. I really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This pull request is waiting on #65 to be merged in to avoid merge conflicts about generated
Routetypes.WHY are these changes introduced?
Fixes #11 by adding admin authenticate middleware at the top level of
/approute.This change also protects the
/app/additionalpage provided by this template, which currently lacks a loader with anadmin.authenticatecall and is publicly accessible outside of the Shopify Admin UI.Checklist
README.mdfile and other related documentation, if applicableCHANGELOG.md