-
Notifications
You must be signed in to change notification settings - Fork 49
Encapsulate Newton iteration in Integrator class (#442) #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eleven7825
wants to merge
42
commits into
SimVascular:main
Choose a base branch
from
Eleven7825:feature/issue-442-integrator-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
c5efb59
Add CMake build artifacts and vim swap files to .gitignore
Eleven7825 b324b1f
Add Integrator class to encapsulate Newton iteration logic
Eleven7825 c4609d5
Refactor main.cpp to use Integrator class
Eleven7825 7eec430
Fix: Add missing iEqOld variable for output calls
Eleven7825 d095026
Merge branch 'main' into feature/issue-442-integrator-class
mrp089 1d7c5cf
change license header
mrp089 fbe9c34
Rename integrator files to Integrator to follow class naming convention
Eleven7825 d3d942f
Convert Integrator class documentation to Doxygen format
Eleven7825 0113997
Refactor istr to be a class member variable
Eleven7825 9955e3d
De-clutter step() method by moving debug writes to individual functions
Eleven7825 8dbde2f
Standardize terminology to use 'Newton iteration' instead of 'inner l…
Eleven7825 7065339
Move dmsg debug statements into respective Integrator helper functions
Eleven7825 f2ee520
Remove pic namespace and integrate functions into Integrator class
Eleven7825 98d09f0
Extract An, Dn, and Yn from ComMod to Integrator class
Eleven7825 8e2f9d6
Extract Ao, Do, Yo from ComMod to Integrator class
Eleven7825 bbb88d6
Merge remote changes with Ao, Do, Yo extraction work
Eleven7825 9b52ad5
Thread Do/Dn displacement parameters through all boundary condition a…
Eleven7825 316d6da
Fix Do/Dn displacement parameter threading for moving mesh simulations
Eleven7825 63e5753
Merge branch 'main' into feature/issue-442-integrator-class
mrp089 4407dc1
Merge branch 'main' into feature/issue-442-integrator-class
mrp089 65d3eec
address mrp089's comments on renaming methods and remove redundant va…
22459d8
remove Do checks and some comments of Ao, Yo, Do
39f0b94
Merge branch 'main' into feature/issue-442-integrator-class
Eleven7825 e4f88d3
Lump An, Dn, Yn, Ao, Do, Yo into solu_state_vars
Eleven7825 ccf7ecd
Change `solutions` struct to be nested, for example `solution.old.A` …
Eleven7825 ec07838
Change the argument positions at `all_fun.h`. Now Dn and Do no longer…
ca653bb
Fix the function signature gnnb at nn.cpp to make Dn and Do not take …
1f4acb8
Add Solution getters to ComMod.h and update Integrator to use them
695f9d6
Update boundary condition functions to use SolutionStates
75db517
Refactor ris functions to use SolutionStates and remove temp_solution…
f0eacd7
Update eq_assem functions to use SolutionStates
5917389
Update txt functions to use SolutionStates
c49aff3
Update output functions to use SolutionStates
7309075
Update initialization functions to use SolutionStates
a73c528
Update all_fun integ functions and uris functions to use SolutionStates
7bd5223
Merge branch 'main' into feature/issue-442-integrator-class
mrp089 d6919af
Update txt functions and uris functions to use SolutionStates
3b23497
Fix missed integ call in uris_meanp
7716ab5
Merge branch 'feature/issue-442-integrator-class' of github.com:Eleve…
93a60f6
Merge branch 'main' into feature/issue-442-integrator-class
mrp089 eb75141
Merge branch 'main' into feature/issue-442-integrator-class
Eleven7825 b5ca973
Add const to read-only SolutionStates& params and pass SolutionStates…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all those
.gitignore's necessary?