Skip to content

Piecewise Chamber and Valve#201

Merged
mrp089 merged 52 commits intoSimVascular:masterfrom
rjrios915:PiecewiseChamberAndValve
Jan 23, 2026
Merged

Piecewise Chamber and Valve#201
mrp089 merged 52 commits intoSimVascular:masterfrom
rjrios915:PiecewiseChamberAndValve

Conversation

@rjrios915
Copy link
Contributor

@rjrios915 rjrios915 commented Nov 17, 2025

Added Piecewise Chamber and Valve

Current situation

I developed I model based on the equations outline in Regazzoni's heart model which required the implementation of a new heart block as well as new values.1

  1. Regazzoni, F., et al. “A cardiac electromechanical model coupled with a lumped-parameter model for closed-loop blood circulation.” Journal of Computational Physics, vol. 457, May 2022, p. 111083, https://doi.org/10.1016/j.jcp.2022.111083.

Release Notes

  • Adds a elastic heart block
  • Adds a piecewise valve

Documentation

Added Doxygen for all blocks.

Testing

Added a closed loop test case validated against an existing model.

Code of Conduct & Contributing Guidelines

@mrp089 mrp089 self-requested a review November 21, 2025 16:41
Copy link
Member

@mrp089 mrp089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjrios915, please review all files/folders in this PR and check if you actually intend on modifying them (see comments for #202).

@ncdorn
Copy link
Contributor

ncdorn commented Jan 20, 2026

I'll take this and #202 over and try to get this fixed up asap as there is renewed interest in the lab for this feature

@ncdorn
Copy link
Contributor

ncdorn commented Jan 22, 2026

alright I think i've cleaned this up. @mrp089 there is one discrepancy - on my local machine the tests for cases with a valve are not passing as the result solution contains the new valve_status variable. however for some reason the tests pass fine on teh Github CI pipeline. I have updated the reference solutions to include the valve_status variable which is why the tests are not passing. any thoughts on why this is happening? is Github CI not using the most up-to-date build?

@mrp089
Copy link
Member

mrp089 commented Jan 22, 2026

Nice! The failing test cases show up as modified. You have to check them out from master and commit them to reset.

@ncdorn ncdorn force-pushed the PiecewiseChamberAndValve branch from 13dc8fa to 8363828 Compare January 23, 2026 00:56
@ncdorn
Copy link
Contributor

ncdorn commented Jan 23, 2026

alright this should be all cleaned up and ready to go! @mrp089 let me know if I missed anything here

@ncdorn ncdorn mentioned this pull request Jan 23, 2026
1 task
@mrp089 mrp089 merged commit a1f5eca into SimVascular:master Jan 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments