Piecewise Chamber and Valve#201
Conversation
… into RegChamber
… into RickyRegChamber
mrp089
left a comment
There was a problem hiding this comment.
@rjrios915, please review all files/folders in this PR and check if you actually intend on modifying them (see comments for #202).
|
I'll take this and #202 over and try to get this fixed up asap as there is renewed interest in the lab for this feature |
|
alright I think i've cleaned this up. @mrp089 there is one discrepancy - on my local machine the tests for cases with a valve are not passing as the result solution contains the new valve_status variable. however for some reason the tests pass fine on teh Github CI pipeline. I have updated the reference solutions to include the valve_status variable which is why the tests are not passing. any thoughts on why this is happening? is Github CI not using the most up-to-date build? |
|
Nice! The failing test cases show up as modified. You have to check them out from master and commit them to reset. |
13dc8fa to
8363828
Compare
|
alright this should be all cleaned up and ready to go! @mrp089 let me know if I missed anything here |
Added Piecewise Chamber and Valve
Current situation
I developed I model based on the equations outline in Regazzoni's heart model which required the implementation of a new heart block as well as new values.1
Release Notes
Documentation
Added Doxygen for all blocks.
Testing
Added a closed loop test case validated against an existing model.
Code of Conduct & Contributing Guidelines