Add two-hill activation function and refactor chamber elastance models with proper separation of concerns#213

Closed

Copilot wants to merge 23 commits intomasterfrom

copilot/add-two-hill-activation-function

Commits on Feb 10, 2026

Initial plan
Copilot
committed
Add ActivationFunction class and rename PiecewiseCosineChamber to LinearElastanceChamber

Copilot
and
aabrown100-git
committed
Refactor ChamberElastanceInductor and LinearElastanceChamber to use ActivationFunction

Copilot
and
aabrown100-git
committed
Add test cases for two hill activation function

Copilot
and
aabrown100-git
committed
Address code review comments: improve readability and documentation

Copilot
and
aabrown100-git
committed
Add documentation for activation functions

Copilot
and
aabrown100-git
committed
Support string activation_function_type and nested activation_function_values in JSON

Copilot
and
aabrown100-git
committed
Refactor initialize_activation_function to use factory method in ActivationFunction

Copilot
and
aabrown100-git
committed
Make activation function parameters members of ActivationFunction instances

Copilot
and
aabrown100-git
committed
Store cardiac_period as member of ActivationFunction base class

Copilot
and
aabrown100-git
committed
Make PiecewiseCosineChamber an alias to LinearElastanceChamber for backward compatibility

Copilot
and
aabrown100-git
committed
Remove backward compatibility code and require activation_type parameter

Copilot
and
aabrown100-git
committed
Remove activation function parameters from LinearElastanceChamber and flat parameter backward compatibility

Copilot
and
aabrown100-git
committed
Remove PiecewiseCosineChamber from factory registration and type checks

Copilot
and
aabrown100-git
committed
Remove PiecewiseCosineChamber completely - no longer needed with activation function separation

Copilot
and
aabrown100-git
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add two-hill activation function and refactor chamber elastance models with proper separation of concerns#213

Add two-hill activation function and refactor chamber elastance models with proper separation of concerns#213
Copilot wants to merge 23 commits intomasterfrom
copilot/add-two-hill-activation-function

Commits on Feb 10, 2026

Initial plan

Add ActivationFunction class and rename PiecewiseCosineChamber to LinearElastanceChamber

Refactor ChamberElastanceInductor and LinearElastanceChamber to use ActivationFunction

Add test cases for two hill activation function

Address code review comments: improve readability and documentation

Add documentation for activation functions

Support string activation_function_type and nested activation_function_values in JSON

Refactor initialize_activation_function to use factory method in ActivationFunction

Make activation function parameters members of ActivationFunction instances

Store cardiac_period as member of ActivationFunction base class

Make PiecewiseCosineChamber an alias to LinearElastanceChamber for backward compatibility

Remove backward compatibility code and require activation_type parameter

Remove activation function parameters from LinearElastanceChamber and flat parameter backward compatibility

Remove PiecewiseCosineChamber from factory registration and type checks

Remove PiecewiseCosineChamber completely - no longer needed with activation function separation

Commits on Feb 11, 2026

Improve error reporting to list all missing parameters at once

Fix BlockType enum values to be sequential (piecewise_valve = 17, linear_elastance_chamber = 18)

Commits on Feb 12, 2026

Fix compilation error: use vector size check instead of non-existent count() method

Make activation_type a required parameter for ChamberElastanceInductor

Remove backward compatibility for numeric activation_type parameter - only support activation_function_type string

Update chamber_elastance_inductor test case with activation function

Update documentation to reflect mandatory string-based activation_function_type parameter

Add comprehensive validation for activation_function_type and activation_function_values parameters

Comments