fix: 🐛 correct usage of provide after unmount#191
Merged
aditya-css merged 1 commit intoSimformSolutionsPvtLtd:mainfrom Jun 18, 2024
Merged
Conversation
Contributor
Author
|
Part of #187 |
aditya-css
requested changes
Jun 18, 2024
Collaborator
aditya-css
left a comment
aditya-css
left a comment
There was a problem hiding this comment.
Can you please do this for other extensions related to inherited widget as well?
jonasbadstuebner
force-pushed
the
fix-provide-usage-after-unmount
branch
from
9cbfcc8 to
2f1b7dd
Compare
Collaborator
|
Thanks @jonasbadstuebner. Can you please mention this commit in changelog as well? |
jonasbadstuebner
force-pushed
the
fix-provide-usage-after-unmount
branch
from
2f1b7dd to
ff1897b
Compare
Contributor
Author
|
@aditya-css Like so? |
aditya-css
requested changes
Jun 18, 2024
jonasbadstuebner
force-pushed
the
fix-provide-usage-after-unmount
branch
from
ff1897b to
7d1f066
Compare
aditya-css
approved these changes
Jun 18, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
provideI got some error messages that could all be prevented at the root by checking if the state is mounted.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
#187