fix: 🐛 prevent actions if receiver is not capable of dealing with them#192
Merged
aditya-css merged 1 commit intoSimformSolutionsPvtLtd:mainfrom Jun 18, 2024
Conversation
aditya-css
requested changes
Jun 18, 2024
Collaborator
aditya-css
left a comment
aditya-css
left a comment
There was a problem hiding this comment.
Can you please ensure to cover all the usage of messageStreamController.sink.add with isClosed check? Also, please add this to changelog.
jonasbadstuebner
force-pushed
the
fix-actions-on-unhealthy-targets
branch
from
4f9c683 to
c9439b6
Compare
aditya-css
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sometimes I got errors when the receiver of these calls was unable to handle the request. This PR checks if the receiver is "healthy enough" to handle the requested call.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
#187