fix: 🐛 dispose all ValueNotifiers and ScrollControllers in ChatController.#194
Merged
aditya-css merged 1 commit intoSimformSolutionsPvtLtd:mainfrom Jun 19, 2024
Conversation
aditya-css
requested changes
Jun 18, 2024
Collaborator
aditya-css
left a comment
aditya-css
left a comment
There was a problem hiding this comment.
Can you please also dispose _showTypingIndicator and scrollController?
Also, please update the documentation comment of the dispose function and the commit message & PR Title to reflect the same.
jonasbadstuebner
force-pushed
the
fix-dispose-replysuggestion
branch
from
d8cc319 to
99963c7
Compare
jonasbadstuebner
changed the title
ValueNotifiers and ScrollControllers in ChatController.
aditya-css
requested changes
Jun 18, 2024
jonasbadstuebner
force-pushed
the
fix-dispose-replysuggestion
branch
from
99963c7 to
7b05a0a
Compare
jonasbadstuebner
force-pushed
the
fix-dispose-replysuggestion
branch
from
7b05a0a to
5759f26
Compare
aditya-css
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_replySuggestionshould be disposed as well.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
#187