[MS-1351] Adding system bar insets for ExternalCredentialControllerFragment#1593
Merged
alexandr-simprints merged 2 commits intorelease/2025.4.1from Feb 17, 2026
Conversation
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
Copilot,
luhmirin-s and
meladRaouf
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a bug where UI elements were covered by the system UI on multiple external credential workflow screens. However, the fix is applied to the wrong fragment. The ExternalCredentialControllerFragment is a navigation controller fragment that only hosts an internal navigation graph, and according to the codebase conventions, should not have system bar insets applied to avoid double padding.
Changes:
- Added
applySystemBarInsets(view)call toExternalCredentialControllerFragment.onViewCreated()
...prints/feature/externalcredential/screens/controller/ExternalCredentialControllerFragment.kt
Outdated
Show resolved
Hide resolved
luhmirin-s
approved these changes
Feb 17, 2026
|
alexandr-simprints
deleted the
MS-1351-mfid-system-ui-is-overlapping-the-buttons-at-the-bottom-of-the-screen
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.1
Root cause analysis (for bugfixes only)
First known affected version: 2025.4.0
Notable changes