Fix for SirHurt Executor Incompatibility.#34
Fix for SirHurt Executor Incompatibility.#34tomatotxt wants to merge 1 commit intoSiriusSoftwareLtd:mainfrom
Conversation
Damian-11
left a comment
There was a problem hiding this comment.
Looks good to merge. It's a shame that one of the most popular executors in this space refuses (or lacks the competence) to properly implement such a basic feature. We're stuck sacrificing code readability for compatibility.
|
If your executor does not support string interpolation, you probably shouldn't be using it in the first place. If you want Rayfield to work with those executors, you can simply fork it. |
RayField is a very popular UI library and SirHurt is a very popular executor them being compatible with each other is in the best interest of all RayField users who paid for SirHurt. These changes have no drawbacks other then readability but RayField barely get's any significant updates at this point anyways. I did fork it and created a tool for people to use that auto fixes this but I asked RayField support and they told me the best thing to do was make a pull request here so I did. |
SirHurt Executor has issues with Luau String Interpolation. As of today, they have not fixed these issues. Therefore, I have made this pull request which simply fixes it for SirHurt Executor by replacing string interpolation instances with their concatenation and tostring code equivalents. IMPORTANTLY, this does NOT affect its compatibility with other executors.