Skip to content

add f-string to test package arg #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SkeneZr wants to merge 4 commits into
base: master
Choose a base branch
from
+5 −2
Open

add f-string to test package arg #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82ab934
add f-string to test package arg
SkeneZr Apr 18, 2025
fec27c6
Update VERSION
SkeneZr May 20, 2025
1503ec1
Update ChangeLog
SkeneZr May 20, 2025
a8136cb
Update ChangeLog
SkeneZr May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
Version 0.4.5
-------------
* fix `java_test` using f-string to test package arg
Version 0.4.4
-------------
* `java_runtime_image` provides an entry point so it can be referenced directly
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.4.4
0.4.5
2 changes: 1 addition & 1 deletion build_defs/java.build_defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def java_test(name:str, srcs:list, resources:list=None, resources_root:str=None,
else:
java = CONFIG.JAVA.JAVA_TOOL

test_package_arg = "-Dbuild.please.testpackage={test_package}" if test_package is not None else ""
test_package_arg = f"-Dbuild.please.testpackage={test_package}" if test_package is not None else ""

cmd = 'ln -s "$(if [ -f "$TOOLS_JUNIT" ]; then echo "$TOOLS_JUNIT"; else echo "$(which "$TOOLS_JUNIT")"; fi)" . && ' + cmd
test_cmd = f"$TOOLS_JAVA {test_package_arg} {jvm_args} -jar $(location :{name}) {flags}"
Expand Down