Type ObjectProxy more precisely; drop unsafe cast#661
Open
bennostein wants to merge 3827 commits intoSkipLabs:mainfrom
Open
Type ObjectProxy more precisely; drop unsafe cast#661bennostein wants to merge 3827 commits intoSkipLabs:mainfrom
bennostein wants to merge 3827 commits intoSkipLabs:mainfrom
Conversation
As it says on the tin. I noticed this while writing up resource/service docs, and couldn't think of any case where it makes sense to have a service with no output resources. Nor does any such case exist in our examples.
... and provide a cleanup callback in the hackernews example's useEffect code
Not a lot to say here, really -- using SSEs means that there's not a ton of Skip-specific work to do on the client. So, I dive quickly into the actual event-stream data sent over the wire, give some examples of how to work with it in client code, and also show how synchronous reads work.
... due to redundancy with PATCH route
High-level description of the resource/service abstraction layer, and route-by-route documentation of the control and streaming HTTP APIs.
`userID` -> `UserID`
Alternative to SkipLabs#642
Fix SkipLabs#648 + moving code from proxy to ObjectHandle
mbouaziz
reviewed
Jan 17, 2025
| keys: IterableIterator<keyof Base>; | ||
| } & Base; | ||
| export type ObjectProxy<Base extends { [k: string]: Exportable }> = | ||
| ObjectHandle<Internal.CJObject> & |
Contributor
There was a problem hiding this comment.
Not sure about this, e.g. I don't think you can access .pointer directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this the other day while investigating #648 ; giving a better type to
ObjectProxys lets us avoid the spookyexpr as unknown as typecast