Hotfix proper jms message charset

[privettoli]

Use charset from the JMS message or UTF-8 but never use defaultCharset (on Windows it's Win1252) when converting a text to bytes before sending to a broker.
I've found out that bug when our testers created a bug that our app produce symbols like ????? on the places of charset-specific symbols like German and French.

[privettoli]

@spindelmanne, @erikryverling, please, review

[spindelmanne]

Thanks for your contribution! We will review it and get back to you shortly.

[spindelmanne]

I just noticed you haven't signed our Contributor license agreement yet. You can download it from here:

https://dl.dropboxusercontent.com/u/81603711/SmartBear_Contributor_License_Agreement.pdf

Could you sign it and send it to us? This is just to let us use your solution in our commercial version without any legal issues.

[privettoli]

@spindelmanne where should I send it?

[spindelmanne]

You can just email a photo of the signed agreement to manne dot fagerlind at smartbear dot com.

[joeljons]

I think he just did. Replace the dot with . and at with @

[privettoli]

@spindelmanne I've sent. Can you confirm?

[spindelmanne]

Hello, finally looking at your PR. I have some issues with you replacing "UTF-8" with StandardCharsets.UTF8. I'm all for doing this (but I would static import it to make the code read better), but if so it should be done consistently in the project. There are currently 519 occurrences of the string "UTF-8", which is obviously technical debt that we should do something about, and you're only changing a couple of them.

Do you mind rolling back those changes? As far as I can see, the rest of the PR is good stuff!

[spindelmanne]

Hey, @privettoli , did you see my comment?

[privettoli]

@spindelmanne, I just was unavailable for these days. Okay, so, as you could see, changes from the hard coded Strings to the StandardCharset constant are in a separate commit, so yeah, we could do revert for these changes.

[privettoli]

@spindelmanne, or I can replace all remaining hardcoded Strings with appropriate constants.

[spindelmanne]

I prefer to do that as a separate change. It's such a huge code change (although it should not break anything, of course) that I need to do it in collaboration with the SoapUI OS dev team and QA. So just revert the commit for now, OK?