add namespacer info and update composer, update symfony, add claude docs (WP-982) #602
Conversation
| "require": { | ||
| "galbar/jsonpath": "^2.0", | ||
| "vsolovei-smartling/retry": "^2.0.1", | ||
| "jralph/retry": "3.0.0", |
There was a problem hiding this comment.
jralph/retry 3.0.0 includes a pr from vsolovei-smartling/retry 2.0.1
| "symfony/dependency-injection": "~5.4", | ||
| "symfony/expression-language": "~5.4", | ||
| "symfony/config": "~5.4", | ||
| "symfony/yaml": "~5.4", |
There was a problem hiding this comment.
Required changes as more and more libraries are using php 8+
| - "%plugin.name%" | ||
| - "%plugin.version%" | ||
| - "%plugin.url%" | ||
| - "@=service('wp.proxy').plugin_dir_url(constant('SMARTLING_PLUGIN_DIR')~constant('DIRECTORY_SEPARATOR')~'..')" |
There was a problem hiding this comment.
No more dynamic parameters in symfony 5
| "./inc/third-party/vsolovei-smartling/namespacer/bin/namespacer --composer ./composer.json --package smartling-connector --namespace \"Smartling\\Vendor\" inc", | ||
| "php fix-double-namespace.php" |
There was a problem hiding this comment.
Can you explain this please? I don't get what is broken and why it's broken and what does this custom script do.
There was a problem hiding this comment.
When namespacing, Smartling/Vendor namespace is sometimes appended more than once. The custom script removes the duplicate prefix until none are found
There was a problem hiding this comment.
can we fix the root cause instead of consequences? or the root cause is somewhere deep in 3rd parties?
| @@ -0,0 +1,282 @@ | |||
| # Elementor Content Processing Guide | |||
There was a problem hiding this comment.
Ho do you use this file with claude? It's not inside .claude/... folder (prompt/skill/etc), you manually reference it?
I propose to convert this to the skill or prompt and pack it to one of our plugins (or create new one). Take a look here: https://github.com/Smartling/claude-plugins
sounds like a new int-team-wp plugin for claude to me.
There was a problem hiding this comment.
Is referenced in claude.md on line 124
This pr includes changes for automatically handling dependency scoping after each composer update, as is required for proper code changes