Keep overlay open if a child of the overlay or target is focused#40
Open
hsource wants to merge 1 commit intoSnosMe:masterfrom
Open
Keep overlay open if a child of the overlay or target is focused#40hsource wants to merge 1 commit intoSnosMe:masterfrom
hsource wants to merge 1 commit intoSnosMe:masterfrom
Conversation
Contributor
Author
|
@SnosMe As a heads up - this fixes 1 of the 2 main remaining issues with awakened-poe-trade on Mac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While working on awakened-poe-trade, I realized that opening up the file selection dialog for picking an image caused the overlay to close. This is because it's a subwindow.
Fix
Don't fire a blur event for children of either the target or overlay.
Testing
Tested target children with TextEdit; overlay children with awakened-poe-trade
Target
Target.child.mp4
Overlay
Overlay.child.mp4