Conversation
Contributor
Author
|
Actually this diff on #43 is interesting: 
Please feel free to commit to this branch if that's a relevant change |
scutuatua-crypto
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @SnosMe uh sorry this is kinda awkward, looks like I broke something in #45 - just pulled latest to my personal project and I'm getting this build error:
I don't write in C and I didn't touch that file so not sure exactly what the hell is going on here, Copilot says:
Seems to be right, as docs agree with expected type: https://nodejs.org/api/n-api.html#napi_create_buffer
I deleted and re-cloned this repo and started getting the issue here as well (guess I fixed it locally a while ago and forgot so I never committed?), changes in this PR fix those issues and I can run demo successfully after this change.
Patching this locally fixes build in my personal project, please double check this PR though as I have never written a line of C in my life :^)