httpoverrpc: permit override of host-header in requests sent by the 'proxy' command. #598
Open
sfc-gh-jallie wants to merge 3 commits intomainfrom
Open
httpoverrpc: permit override of host-header in requests sent by the 'proxy' command. #598sfc-gh-jallie wants to merge 3 commits intomainfrom
sfc-gh-jallie wants to merge 3 commits intomainfrom
Conversation
sfc-gh-mwalas
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a small change to the
httpoverrpcproxycommand to permit callers to specify a host-header to be set on requests received by the client proxy.This simplifies a common pattern where
proxyis used to tunnel requests to a host which normally expects to receive those requests over a public interface, and is expecting a particularhost:value.Without this change, callers were left with two bad options:
--allow-any-hostto true and--hostnameto the expected 'host' value, and hope (or arrange) for the destination host to resolve this to localhostThis fix, instead, affects only the request itself, and does not require the
--allow-any-hostflag or alterations to client DNS.New tests have been added, in the pattern of the existing tests.