Fix pre-Initialized ExtEvents not invoking#13
Open
combobulator wants to merge 1 commit intoSolidAlloy:mainfrom
Open
Fix pre-Initialized ExtEvents not invoking#13combobulator wants to merge 1 commit intoSolidAlloy:mainfrom
combobulator wants to merge 1 commit intoSolidAlloy:mainfrom
Conversation
…to allow manually Initialized PersistentListeners to Invoke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current commit, the
PersistentListener._initializationSuccessfulflag is only set when thePersistentListenerinitializes itself during invocation. ThePersistentListener._initializationCompleteflag is set properly during the initialization call. Both of these flags must be set for the invocation to execute.This leads to a failure to invocate, with no error message, if
ExtEvent.Initialize()is called beforeExtEvent.Invoke(); the containedPersistentListeners will have the_initializationCompleteflag set, but_initializationSuccessfulnot set, in spite of no issues.This PR sets the
_initializationSuccessfulflag withinPersistentListener.Initialize()so pre-initializedExtEvents will fire properly.