Fixed giving null assembly name when assembly is present.#11
Open
12Acorns wants to merge 2 commits intoSolidAlloy:masterfrom
Open
Fixed giving null assembly name when assembly is present.#1112Acorns wants to merge 2 commits intoSolidAlloy:masterfrom
12Acorns wants to merge 2 commits intoSolidAlloy:masterfrom
Conversation
See [this](SolidAlloy/GenericUnityObjects#39 (comment)) for explanation.
Author
|
This specifically fixes an issue with GenericUnityObjects on unity 2022 (and possibly up) |
12Acorns
commented
Dec 28, 2024
Author
12Acorns
left a comment
12Acorns
left a comment
There was a problem hiding this comment.
Should work fine, if any problems just let know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, as of unity 2022 (did not test any newer), if an assembly does not have a dot '.' in its name the function:
GetAssemblyName(Args)will return an empty string, instead of the assemblyName.Instead, the method should only return an empty string if the assemblyName is empty/null, and return the assemblyName if the dotIndex is -1 (else perform the string split)