feat: SerializableDictionary implements IReadOnlyDictionary<TKey, TValue>#6
Open
afti-githobo wants to merge 1 commit intoSolidAlloy:masterfrom
Open
feat: SerializableDictionary implements IReadOnlyDictionary<TKey, TValue>#6afti-githobo wants to merge 1 commit intoSolidAlloy:masterfrom
afti-githobo wants to merge 1 commit intoSolidAlloy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to use IReadOnlyDictionary types when passing around dictionaries that shouldn't be modified by the code that's receiving them, but SerializableDictionary didn't implement the interface. It was, however, a very minor addition, so I just went ahead and did that.
I... haven't done a lot of open-source contributions in the past, tbh, so I hope I haven't done anything wrong and I'm not stepping on any toes?
Anyway, the code should be pretty self-explanatory; I didn't really have to do much of anything to implement the interface. Just a small quality-of-life improvement for using the collection in certain programming patterns.