Fix incorrect editor style name for Unity 2022.3+#2
Open
Shimmermare wants to merge 2 commits intoSolidAlloy:mainfrom
Open
Fix incorrect editor style name for Unity 2022.3+#2Shimmermare wants to merge 2 commits intoSolidAlloy:mainfrom
Shimmermare wants to merge 2 commits intoSolidAlloy:mainfrom
Conversation
|
Would love for this change to go through, stumbled on it today as well. |
|
I think this would break retrocompatibility. A null check and e default to the old typoed string should be preferred. |
|
Oh, sorry I read the unity commit as the one of a PR. You use a define check. Perfect. This also happens in UnityDropdown. |
Author
|
Replaced version defines check with simple null check because this change was ported to Unity 2021, 2022 and 2023. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Unity 2022.3 they fixed typo in style name.
Unity-Technologies/UnityCsReference@da51b77#diff-d4e399fabac0c73f6f6580b4c4094492ab460619fb45fe621764230982beefd3
Same problem in SolidUtilities: SolidAlloy/SolidUtilities#9