Issue 26: Refactor Spotify launch process to handle Flatpak spotify when minimizing window#27
Open
guzzdev wants to merge 1 commit intoSonath21:mainfrom
Open
Issue 26: Refactor Spotify launch process to handle Flatpak spotify when minimizing window#27guzzdev wants to merge 1 commit intoSonath21:mainfrom
guzzdev wants to merge 1 commit intoSonath21:mainfrom
Conversation
Owner
|
Looks good, for now I can’t merge it because I need to test it locally as well, also cleanly check if the code follows all gnome 45+ standards (seems to, but I don’t see any clean up in the destructor, maybe not needed in this case). Will merge when I find the time to check it out. |
Author
|
Unsure about clean up, did not think about it. Let me know if you need any change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue 26
Tested on same fail condition as described in issue (Fedora 43, Flatpak Spotify).
Fallback launch if no Spotify window is found after scanning all window actors, the extension now calls
_launchSpotifyProcess()so Spotify is started._launchSpotifyProcess()tries the native spotify command first, then falls back toflatpak run com.spotify.Client, so native and Flatpak installs are supported when the user clicks the indicator and no window exists.I will be glad to hear if you would do it differently.