[engine] Fix a downcast issue possibly causing physics bugs#109
Open
RaphaelIT7 wants to merge 1 commit intoSource-Authors:masterfrom
Open
[engine] Fix a downcast issue possibly causing physics bugs#109RaphaelIT7 wants to merge 1 commit intoSource-Authors:masterfrom
RaphaelIT7 wants to merge 1 commit intoSource-Authors:masterfrom
Conversation
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
b388518 to
76fe8e0
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
41bd79f to
9544370
Compare
dimhotepus
force-pushed
the
master
branch
11 times, most recently
from
3fd9d80 to
dbb5131
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
1d814a3 to
e099636
Compare
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
a98b892 to
8f28882
Compare
dimhotepus
force-pushed
the
master
branch
8 times, most recently
from
2a20613 to
b8ee27e
Compare
This was a bug that was found in gmod & fixed there, if the MAX_MAP_BRUSHSIDES was raised, any brush that had brush sides above the limit would have no collisions. So this would only be a issue if you were to raise it.
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
739a853 to
a997975
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
a237f58 to
6699560
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
1319e7e to
08258ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a downcast issue that could possibly cause physics issues in the future
This was a bug that was found in gmod & fixed there, if the MAX_MAP_BRUSHSIDES was raised, any brush that had brush sides above the limit would have no collisions.
So this would only be a issue if you were to raise it.