engine: make multiple things more threadsafe#157
Closed
RaphaelIT7 wants to merge 1 commit intoSource-Authors:masterfrom
Closed
engine: make multiple things more threadsafe#157RaphaelIT7 wants to merge 1 commit intoSource-Authors:masterfrom
RaphaelIT7 wants to merge 1 commit intoSource-Authors:masterfrom
Conversation
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
739a853 to
a997975
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
a237f58 to
6699560
Compare
Member
|
I will close these thread-safety PRs for now. The problem is they make entities more threadsafe, but not fully threadsafe. If all is const, it means entities are immutable and can be used anywhere without syncronization overhead If logically or by ThreadSanitizer we find a real bug, such PRs will be accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #160 for
AUTO_LOCK_[WRITE/READ]