engine: fix up NET_FindOrCreateSplitPacketEntry#171
Merged
dimhotepus merged 1 commit intoSource-Authors:masterfrom Feb 8, 2026
Merged
engine: fix up NET_FindOrCreateSplitPacketEntry#171dimhotepus merged 1 commit intoSource-Authors:masterfrom
dimhotepus merged 1 commit intoSource-Authors:masterfrom
Conversation
RaphaelIT7
force-pushed
the
rmod-patch-8
branch
from
db673e2 to
742aef9
Compare
dimhotepus
added a commit
that referenced
this pull request
Feb 8, 2026
See #171 Thanks to RaphaelIT7!
RaphaelIT7
force-pushed
the
rmod-patch-8
branch
from
ea7c513 to
7c328bd
Compare
Contributor
Author
|
With |
dimhotepus
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing it
With the commit c07099f the function
NET_FindOrCreateSplitPacketEntrywas changed and broken.entrywas never set to a valid value, causing the entire function to basically fail to "Find" a split packet entry.Improving it
I've made a small improvement to use
splitPacketEntries.AddToTailGetPtr();which avoids stack allocatingCSplitPacketEntrytemporarily just to allocate it into the vector anyways- avoiding a possible stack overflow if, for example, some net limits were raised & it became too big.Small assert
I've added a small assert toNET_GetLongas currently in one of my builds I'm getting some corrupted packet numbers and crashes.This is simply to make debugging such things a bit easier.This issue is fixed by #172