Skip to content

engine: fix an overflow if combination of MAX_EDICT_BITS & DELTASIZE_BITS is too much #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaphaelIT7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

engine: fix an overflow if combination of MAX_EDICT_BITS & DELTASIZE_BITS is too much #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion engine/sv_ents_write.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,8 @@ void CBaseServer::WriteDeltaEntities( CBaseClient *client, CClientFrame *to, CCl
bf_write savepos = *u.m_pBuf;

// Save room for number of headers to parse, too
u.m_pBuf->WriteUBitLong ( 0, MAX_EDICT_BITS+DELTASIZE_BITS+1 );
CBitVec<MAX_EDICT_BITS+DELTASIZE_BITS+1> pHeaderBits; // RaphaelIT7: Exists just to pass nothing to WriteBits (all bits are 0 soo it'll be fine)
u.m_pBuf->WriteBits( pHeaderBits.Base(), pHeaderBits.GetNumBits() ); // RaphaelIT7: kept it as it should be faster than 3 WriteUBitLong calls

intp startbit = u.m_pBuf->GetNumBitsWritten();

Expand Down
Loading