Handle NetworkError exceptions in retry logic for parallel requests #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parallel requests share a client via get_all_data(), one request failing can destroy the shared client while others are in-flight. Those requests then fail with ReadError, WriteError, or CloseError (all subclasses of NetworkError) which were not being caught by the retry logic. This fix extends the exception handling in _retry_with_backoff() to catch these network errors alongside RemoteProtocolError, applying the same immediate retry with client recreation strategy. Fixes SpanPanel#89 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_retry_with_backoff()to catchhttpx.ReadError,httpx.WriteError, andhttpx.CloseErroralongsideRemoteProtocolErrorget_all_data()share a client and one request destroys the client while others are in-flightTest plan
TestNetworkErrorRetryLogicclass covering:ReadError,WriteError,CloseErrortrigger immediate retryRemoteProtocolErrorbehavior unchanged (regression test)ConnectErrorstill uses exponential backoff (unchanged)Fixes #89
🤖 Generated with Claude Code