Open
Conversation
Sparker0i
requested changes
Dec 21, 2018
Owner
Sparker0i
left a comment
Sparker0i
left a comment
There was a problem hiding this comment.
Please make the required changes, then make a new PR.
| android:name="android.appwidget.provider" | ||
| android:resource="@xml/small_widget" /> | ||
| </receiver> | ||
| <receiver android:name=".Very_small_widget"> |
Owner
There was a problem hiding this comment.
- It should be placed inside the
widgetsub-package. I can see that it is in the root package. Please make that change - Please follow the naming convention of other receivers. Other receiver names are following PascalCasing.
- I don't see
Very_small_widgetandvery_small_widget_info.xmlfiles. How is this even working then? Are you sure you had committed those 2 files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[screenshot]:
[app debug] :
added_widget.zip