Skip to content

Conversation

@JoeyBF
Copy link
Collaborator

@JoeyBF JoeyBF commented Nov 24, 2022

I think it's a good idea to give the option of not saving homomorphisms and homotopies even when the source has a save directory. It makes quick operations faster since they are less IO-intensive. It will also make it easier to compute Massey products in the future, since right now computing homotopies is limited by IO, and they are only used once anyway

@JoeyBF
Copy link
Collaborator Author

JoeyBF commented Nov 26, 2022

Actually, now that I'm thinking about it a bit more, maybe it would be a better idea to have the option of not writing to disk but still reading what's already there

@dalcde
Copy link
Contributor

dalcde commented Nov 27, 2022

Do you still want to merge this and work on that separately? Also I think it would be better to raise/warn if save is true but there is no save file (maybe make it an enum with Yes/No/Auto?).

@JoeyBF JoeyBF force-pushed the option_save branch 3 times, most recently from 71bb3de to 82e1381 Compare March 8, 2023 15:20
@JoeyBF
Copy link
Collaborator Author

JoeyBF commented Mar 8, 2023

Do you still want to merge this and work on that separately? Also I think it would be better to raise/warn if save is true but there is no save file (maybe make it an enum with Yes/No/Auto?).

That's a good idea, I implemented that with the SaveOption enum. I think it would be worth it to also give the option for primary and secondary resolutions, but that's more intrusive and that raises questions for ergonomics (e.g. what happens when we build a homomorphism with a nontrivial save_option between resolutions that also have nontrivial save_options?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants